Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32716 )
Change subject: vboot: Turn vboot_logic_executed() into a static inline
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/32716/2/src/security/vboot/misc.h
File src/security/vboot/misc.h:
https://review.coreboot.org/#/c/32716/2/src/security/vboot/misc.h@90
PS2, Line 90: else
Not sure about code style: Suggest removing the latest else, having dead_code() default return. […]
I'd call this one a matter of taste (it's not in the code style to my knowledge). In cases where many statements follow in the else block I agree with not indenting them, but where every branch is just a single line and they all present equally weighed options, I think this may read better. Also I'm just moving code around that was already formatted this way.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32716
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I193f608882cbfe07dc91ee90d02fafbd67a3c324
Gerrit-Change-Number: 32716
Gerrit-PatchSet: 2
Gerrit-Owner: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 10 May 2019 18:25:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Frans Hendriks
fhendriks@eltan.com
Comment-In-Reply-To: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-MessageType: comment