Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47259 )
Change subject: soc/intel/tigerlake: Update Kconfig for NEM Enhanced Mode ......................................................................
Patch Set 14: Code-Review+2
(2 comments)
https://review.coreboot.org/c/coreboot/+/47259/14//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/47259/14//COMMIT_MSG@9 PS14, Line 9: IA32_PQR_ASSOC (0xC8F) MSR's Bits[32:33] are used for mask selection : when Kconfig COS_MAPPED_TO_MSB is selected. In cpu/Kconfig, if : INTEL_CAR_NEM_ENHANCED is selected, in tigerlake/Kconfig, selecting : COS_MAPPED_TO_MSB to ensure Bits[32:33] are used for mask selection. This needs update now.
This change switches the selection of CAR mode so that INTEL_CAR_NEM_ENHANCED_V2 is the default unless mainboard selects INTEL_CAR_NEM. INTEL_CAR_NEM is selected only by mainboards using older silicon that did not support NEM enhanced.
https://review.coreboot.org/c/coreboot/+/47259/14/src/mainboard/google/volte... File src/mainboard/google/volteer/Kconfig.name:
https://review.coreboot.org/c/coreboot/+/47259/14/src/mainboard/google/volte... PS14, Line 18: INTEL_CAR_NEM You will need this for tglrvp too.