Xi Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48201 )
Change subject: Makefile.inc: Fix empty output when processing C struct files in CBFS ......................................................................
Patch Set 3:
(3 comments)
https://review.coreboot.org/c/coreboot/+/48201/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/48201/2//COMMIT_MSG@9 PS2, Line 9: , : need to add extra '$'
and we need to quote it by an extra '$'.
Ack
https://review.coreboot.org/c/coreboot/+/48201/2//COMMIT_MSG@10 PS2, Line 10: Another way,
Also, the $(@) in cbfs-files-processor-struct is a temporary file name so we want to replace by $(<) […]
Ack
https://review.coreboot.org/c/coreboot/+/48201/2/Makefile.inc File Makefile.inc:
https://review.coreboot.org/c/coreboot/+/48201/2/Makefile.inc@339 PS2, Line 339: $$(<) --> $$(@)
if $(@) is a random file name then I think what we really want is $(<) instead of $(@).
Understand! but sometimes, output $(@) helps to debug the random temp file if unexpected happens.