Attention is currently required from: Tarun Tuli, Subrata Banik, Kapil Porwal, John Zhao, Sumeet R Pawnikar.
John Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70883 )
Change subject: soc/intel/meteorlake: Add HIDs for Meteor Lake SoC DPTF
......................................................................
Patch Set 5:
(1 comment)
File src/soc/intel/meteorlake/dptf.c:
https://review.coreboot.org/c/coreboot/+/70883/comment/38e1930b_0e8e9e88
PS4, Line 6: static const struct dptf_platform_info mtl_dptf_platform_info = {
u don't need this file. please follow the patch train.
Understood. I sync to dptf_common_code and it seems those platform's dptf.c(i.e, alderlake/dptf.c) files still existing. Will all be cleaned and removed including this meterlake/dptf.c late?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/70883
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I21adb2d4a5b41ca7f06eea8afd8ee26d408dd700
Gerrit-Change-Number: 70883
Gerrit-PatchSet: 5
Gerrit-Owner: John Zhao
john.zhao@intel.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: John Zhao
john.zhao@intel.corp-partner.google.com
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: John Zhao
john.zhao@intel.com
Gerrit-Attention: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Comment-Date: Tue, 20 Dec 2022 21:12:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Gerrit-MessageType: comment