Attention is currently required from: Nico Huber, Michał Żygowski, Kyösti Mälkki. Piotr Król has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52934 )
Change subject: nb/amd/agesa/family14: Use generic allocation functions for northbridge ......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS2:
It hurts me to see how deep in debts this code is and that the community has to constantly pay interest for it. Please do not make things worse by making the review harder than necessary. Every change should be reasoned about in the commit message before review starts. If reviewers constantly have to ask, why this and that, that's a waste of time. If the code should be kept upstream in the long run, unexplained changes and shallow reviews only add additional debts. If nobody wants to invest into the code, better make plans to maintain it on another branch.
We never get so negative feedback in such style. For external entities trying to join coreboot development this would not sound welcoming.
We would understand part of comment if Michał or 3mdeb would continuously provide low quality code, but AFAIK this is not the case here. We would like to understand and learn by examples how we can avoid such comments in future.
Also we would appreciate precise explanation about interest community constantly have to pay, since we feel part of community and also would like to stop paying that interest, if possible.
Last sentence worries me because business-wise it means arbitrary resource requests under the threat of exile. It will effectively cause wiping out any old hardware, even one which is still in wide use. I would appreciate if we can bring that topic to coreboot leadership meeting and talk together about that.