Nick Vaccaro has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40496 )
Change subject: soc/intel/tigerlake: fix call to print_spd_info() ......................................................................
soc/intel/tigerlake: fix call to print_spd_info()
Pointer passed to print_spd_info() from meminit.c needed to be dereferenced first, so this change dereferences it.
BUG=b:154352883 TEST="emerge-volteer coreboot chromeos-bootimage", flash and boot volteer, login to kernel and execute the following cbmem command: localhost ~ # cbmem -c | grep LPDDR4X and verify it returns "SPD: module type is LPDDR4X"
Change-Id: I5ff64121f0d50947c4946e9e02460dfb7319d01a Signed-off-by: Nick Vaccaro nvaccaro@google.com --- M src/soc/intel/tigerlake/meminit.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/40496/1
diff --git a/src/soc/intel/tigerlake/meminit.c b/src/soc/intel/tigerlake/meminit.c index 8664547..4709785 100644 --- a/src/soc/intel/tigerlake/meminit.c +++ b/src/soc/intel/tigerlake/meminit.c @@ -222,7 +222,7 @@ die("Not a valid location(%d) for Memory-down SPD!\n", info->md_spd_loc); }
- print_spd_info((unsigned char *)data); + print_spd_info((unsigned char *) *data); }
void meminit_lpddr4x(FSP_M_CONFIG *mem_cfg, const struct lpddr4x_cfg *board_cfg,