Attention is currently required from: Jonathan Zhang, Christian Walter, Jingle Hsu, Arthur Heymans, Tim Chu, Shelly_Chang@wiwynn.com.
Johnny Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58100 )
Change subject: mb/ocp/deltalake: Fix SMBIOS type 9 bugs
......................................................................
Patch Set 3:
(1 comment)
This change is ready for review.
File src/mainboard/ocp/deltalake/ramstage.c:
https://review.coreboot.org/c/coreboot/+/58100/comment/4dea0d42_7881a136
PS3, Line 281: be aligned with our UEFI reference BIOS. */
This is a bug in UEFI, isn't it? Does FB depend on the incorrect implementation of UEFI? If this is […]
True but at least for Delta Lake FB doesn't depend on the BDF numbers in SMBIOS type 9 and we will make it compatible with the spec in the future projects.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58100
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iea437cdf3da5410b6b7a749a1be970f0948d92d9
Gerrit-Change-Number: 58100
Gerrit-PatchSet: 3
Gerrit-Owner: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Jingle Hsu
jingle_hsu@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Shelly_Chang@wiwynn.com
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jonathan Zhang
jonzhang@fb.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Jingle Hsu
jingle_hsu@wiwynn.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Attention: Shelly_Chang@wiwynn.com
Gerrit-Comment-Date: Tue, 05 Oct 2021 06:04:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jonathan Zhang
jonzhang@fb.com
Gerrit-MessageType: comment