[coreboot-gerrit] Change in ...coreboot[master]: mb/google/hatch: Enable SD card support for hatch

[Maulik V Vaghela (Code Review)]

Maulik V Vaghela has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30545 )

Change subject: mb/google/hatch: Enable SD card support for hatch
......................................................................

Patch Set 20:

(2 comments)

https://review.coreboot.org/#/c/30545/3/src/mainboard/google/hatch/variants/... 
File src/mainboard/google/hatch/variants/baseboard/gpio.c:

https://review.coreboot.org/#/c/30545/3/src/mainboard/google/hatch/variants/... 
PS3, Line 106: };
> > > Yes that was the case earlier, if you take a look at Dragonegg we configure only required GPIOs  […]

I have included all GPIOs related to SD card in this patch itself.

https://review.coreboot.org/#/c/30545/18/src/mainboard/google/hatch/variants... 
File src/mainboard/google/hatch/variants/baseboard/gpio.c:

https://review.coreboot.org/#/c/30545/18/src/mainboard/google/hatch/variants... 
PS18, Line 103: UP_20K
> Let's test the change properly and then push it in.

I have tested changes locally on RVP board and SD card detection works without pull up. So I have removed pull up