Attention is currently required from: Ravi kumar, Shelley Chen, Paul Menzel, mturney mturney, Julius Werner.
Ravi Kumar Bokka has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49392 )
Change subject: sc7280: Add SHRM firmware support
......................................................................
Patch Set 54:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/49392/comment/331583cf_cc9f8089
PS50, Line 9: It use to
It is used to
Done
https://review.coreboot.org/c/coreboot/+/49392/comment/8fbcc3cd_e85b680c
PS50, Line 9: manager,
Dot/period instead of comma.
Done
https://review.coreboot.org/c/coreboot/+/49392/comment/4f6c60d2_4ffb4b5d
PS50, Line 10: DDRSS activities.
Please add more details, what DDRSS is.
Done
https://review.coreboot.org/c/coreboot/+/49392/comment/d7ee797f_1cf3cc7a
PS50, Line 13: TEST=Validated on qualcomm sc7280 development board
How?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49392
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I44484573a829eaefbd34907c6fe78d427506a762
Gerrit-Change-Number: 49392
Gerrit-PatchSet: 54
Gerrit-Owner: Ravi kumar
rbokka@codeaurora.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: mturney mturney
mturney@codeaurora.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Ravi Kumar Bokka
c_rbokka@qualcomm.corp-partner.google.com
Gerrit-Attention: Ravi kumar
rbokka@codeaurora.org
Gerrit-Attention: Shelley Chen
shchen@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: mturney mturney
mturney@codeaurora.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Mon, 05 Jul 2021 18:43:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment