Attention is currently required from: Furquan Shaikh, Henry Sun, Stanley Wu, Paul Fagerburg.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52319 )
Change subject: mb/google/dedede/var/boten: Probe and enable amplifier operation mode
......................................................................
Patch Set 7: Code-Review+2
(1 comment)
Patchset:
PS7:
Assuming that all the upcoming device builds will have their FW_CONFIG provisioned with speaker amplifier configuration, this patch looks good to me.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52319
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I756bfa6f604ed320de9a515821979aa95c869ebf
Gerrit-Change-Number: 52319
Gerrit-PatchSet: 7
Gerrit-Owner: Stanley Wu
stanley1.wu@lcfc.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Allen Cheng
allen.cheng@lcfc.corp-partner.google.com
Gerrit-CC: Kevin Chang
kevin.chang@lcfc.corp-partner.google.com
Gerrit-CC: Rasheed Hsueh
rasheed.hsueh@lcfc.corp-partner.google.com
Gerrit-CC: Sunshine Chao
sunshine.chao@lcfc.corp-partner.google.com
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Henry Sun
henrysun@google.com
Gerrit-Attention: Stanley Wu
stanley1.wu@lcfc.corp-partner.google.com
Gerrit-Attention: Paul Fagerburg
pfagerburg@google.com
Gerrit-Comment-Date: Tue, 11 May 2021 00:18:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment