Hello Alexander Couzens, Patrick Rudolph, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/36371
to look at the new patch set (#5).
Change subject: src/mainboard/lenovo: Use the original lenovo hardware ids for touchpad ......................................................................
src/mainboard/lenovo: Use the original lenovo hardware ids for touchpad
Currently the coreboot's touchpad hardware ids are different from the original lenovo ones, and this causes some problems. On Windows, the touchpad driver can't be automatically matched and installed through Windows Update. On Linux, there maybe also some strange issues (https://bugzilla.kernel.org/show_bug.cgi?id=91541). So it's better to use the original lenovo hardware ids for each model than the PNP-ids. By searching for dmesg logs, I found the following hardware ids for these thinkpad models:
LEN0015 T510: https://bbs.archlinux.org/viewtopic.php?id=120287 T410: ? T420: ? T420s: https://bbs.archlinux.org/viewtopic.php?id=191510 T520: ? T430: https://github.com/farjump/fwtr/blob/master/lenovo/thinkpad-t430/2347ds2/len... T430s: ? T530: ?
LEN0020 X220: https://bbs.archlinux.org/viewtopic.php?id=237669 X230: https://forums.bunsenlabs.org/viewtopic.php?id=2460
LEN0036 T540: https://bugzilla.kernel.org/show_bug.cgi?id=91541
Then I made changes to the ps2_controller.asl and the superio.asl to include their correct ones. Then reboot to Windows and the touchpad driver is automatically installed. Done. But I still have some questions: 1, Is making copies of the ps2_controller.asl a good way? Are there any better methods for doing this? 2, Is there any website that collect dmesg logs so I can search the hardware ids? 3, The keyboard's hardware id maybe different like the touchpad as well. But they are working well, so I haven't looked into it. 4, What should we do for other brands like HP?
Change-Id: Ifb635da99c5e05f987aaf4f172108d788dcc2932 Signed-off-by: dalao dalao@tutanota.com --- M src/drivers/pc80/pc/ps2_controller.asl M src/mainboard/lenovo/t410/acpi/superio.asl M src/mainboard/lenovo/t420/acpi/superio.asl M src/mainboard/lenovo/t420s/acpi/superio.asl M src/mainboard/lenovo/t430/acpi/superio.asl M src/mainboard/lenovo/t430s/acpi/superio.asl M src/mainboard/lenovo/t520/acpi/superio.asl M src/mainboard/lenovo/t530/acpi/superio.asl M src/mainboard/lenovo/x220/acpi/superio.asl M src/mainboard/lenovo/x230/acpi/superio.asl 10 files changed, 14 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/36371/5