Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41667 )
Change subject: AGESA f14/f15tn/f16kb: Clean up buildOpts.c files ......................................................................
Patch Set 6: Code-Review+2
(5 comments)
Thank you for reply. After these "agesa cobwebs" all get merged including this one, I'll try to bring these changes to A88XM-E.
https://review.coreboot.org/c/coreboot/+/41667/6/src/vendorcode/amd/agesa/f1... File src/vendorcode/amd/agesa/f14/Config/PlatformInstall.h:
https://review.coreboot.org/c/coreboot/+/41667/6/src/vendorcode/amd/agesa/f1... PS6, Line 210: OPTION_GFX_RECOVERY
AGESA f14 only has one socket, so this would be the equivalent of disabling it by default. […]
Done
https://review.coreboot.org/c/coreboot/+/41667/6/src/vendorcode/amd/agesa/f1... PS6, Line 239: OPTION_DMI
IIRC, it's about DMI tables. […]
Done
https://review.coreboot.org/c/coreboot/+/41667/6/src/vendorcode/amd/agesa/f1... File src/vendorcode/amd/agesa/f16kb/Config/OptionGnbInstall.h:
https://review.coreboot.org/c/coreboot/+/41667/6/src/vendorcode/amd/agesa/f1... PS6, Line 163: PcieTrainingDistributed
No idea, but all boards seem to use the latter, so I made it the default value.
Done
https://review.coreboot.org/c/coreboot/+/41667/6/src/vendorcode/amd/agesa/f1... File src/vendorcode/amd/agesa/f16kb/Config/PlatformInstall.h:
https://review.coreboot.org/c/coreboot/+/41667/6/src/vendorcode/amd/agesa/f1... PS6, Line 860: CStateModeDisabled
IIRC all f16kb boards were choosing this value. […]
Done
https://review.coreboot.org/c/coreboot/+/41667/6/src/vendorcode/amd/agesa/f1... File src/vendorcode/amd/agesa/f16kb/Proc/CPU/cpuLateInit.h:
https://review.coreboot.org/c/coreboot/+/41667/6/src/vendorcode/amd/agesa/f1... PS6, Line 232: SCOPE_NAME_P
f16kb boards seem to use "P0" instead of "C0" on older families. […]
Done