[coreboot-gerrit] Change in ...coreboot[master]: src/mb/sifive/hifive-unleashed: replace fdt in maskrom

[Philipp Hug (Code Review)]

Philipp Hug has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31047 )

Change subject: src/mb/sifive/hifive-unleashed: replace fdt in maskrom
......................................................................

Patch Set 9: Code-Review-1

We should not add a fdt parser in arch/riscv.
There is one in src/base/device_tree.c.
Unfortunately this one only supports changing the unflattened device-tree and uses malloc, which is why you wrote your own, I guess.

@ron: do you have any ideas here? unflattening seems a bit of an overhead here (and needs malloc, which is only available in ramstage) and the typical changes we need could be done by patching the fdt.