Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38995 )
Change subject: mb/ocp/tiogapass: Enable IPMI KCS
......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/c/coreboot/+/38995/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/38995/1//COMMIT_MSG@8
PS1, Line 8:
Mention why you chose a timeout of 60 seconds.
https://review.coreboot.org/c/coreboot/+/38995/1//COMMIT_MSG@9
PS1, Line 9: Tested on OCP Tioga Pass.
Please add a blank line, or use TEST= line.
Please be more specific, how you tested this.
https://review.coreboot.org/c/coreboot/+/38995/1//COMMIT_MSG@11
PS1, Line 11:
Please remove the blank line.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38995
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3678973736a675ed22b5bc9da20a2ca947220f4b
Gerrit-Change-Number: 38995
Gerrit-PatchSet: 1
Gerrit-Owner: Johnny Lin
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Jingle Hsu
Gerrit-Reviewer: Johnny Lin
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Morgan Jang
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 19 Feb 2020 10:23:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment