YH Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31585 )
Change subject: ec/google/chromeec: fix the error status passing for cbi ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/31585/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/31585/1//COMMIT_MSG@8 PS1, Line 8: : google_chromeec_command() can return non-zero number (both positive : and negative) to indicate error.
That should be fixed instead, shouldn’t it? The convention is, that errors are negative?
Hmmm. Other than the places being modified, all seem to be checking for non-zero as error. So I'm assuming non-zero indicates error (either positive or negative)?