Simon Glass has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36041 )
Change subject: drivers/gfx: Add generic graphics with SSDT generator ......................................................................
Patch Set 8: Code-Review+1
(4 comments)
https://review.coreboot.org/c/coreboot/+/36041/8//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/36041/8//COMMIT_MSG@10 PS8, Line 10: -
https://review.coreboot.org/c/coreboot/+/36041/8/src/drivers/generic/gfx/Kco... File src/drivers/generic/gfx/Kconfig:
https://review.coreboot.org/c/coreboot/+/36041/8/src/drivers/generic/gfx/Kco... PS8, Line 2: bool help?
https://review.coreboot.org/c/coreboot/+/36041/8/src/drivers/generic/gfx/chi... File src/drivers/generic/gfx/chip.h:
https://review.coreboot.org/c/coreboot/+/36041/8/src/drivers/generic/gfx/chi... PS8, Line 19: drivers_generic_gfx_privacy_screen_config Should there be any comments on these structs?
https://review.coreboot.org/c/coreboot/+/36041/8/src/drivers/generic/gfx/gfx... File src/drivers/generic/gfx/gfx.c:
https://review.coreboot.org/c/coreboot/+/36041/8/src/drivers/generic/gfx/gfx... PS8, Line 20: chip Is there an ordering rule on includes?