Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39003 )
Change subject: drivers: Replace multiple fill_fb_framebuffer with single instance ......................................................................
Patch Set 16:
(3 comments)
https://review.coreboot.org/c/coreboot/+/39003/16//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39003/16//COMMIT_MSG@7 PS16, Line 7: fb *lb* :)
below too
https://review.coreboot.org/c/coreboot/+/39003/16/src/device/oprom/realmode/... File src/device/oprom/realmode/x86.c:
https://review.coreboot.org/c/coreboot/+/39003/16/src/device/oprom/realmode/... PS16, Line 212: static int vbe_mode_info_valid(void) : { : return mode_info_valid; : } Not used anymore?
https://review.coreboot.org/c/coreboot/+/39003/16/src/drivers/intel/fsp1_1/r... File src/drivers/intel/fsp1_1/ramstage.c:
https://review.coreboot.org/c/coreboot/+/39003/16/src/drivers/intel/fsp1_1/r... PS16, Line 116: Quark X1000's Didn't we ditch Quark's FSP 1.1?