Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35377 )
Change subject: lib/fmap: Cache FMAP in cbmem ......................................................................
Patch Set 10:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35377/9/src/lib/fmap.c File src/lib/fmap.c:
https://review.coreboot.org/c/coreboot/+/35377/9/src/lib/fmap.c@221 PS9, Line 221: /* Don't set fmap_cache so that find_fmap_directory will use regular path */
nit: maybe that's just me but I'd avoid multiple lines without braces around them, even if the other […]
Done
https://review.coreboot.org/c/coreboot/+/35377/9/src/lib/fmap.c@231 PS9, Line 231: fmap_register_cache
nit: Sorry, I meant "register" for the other one. […]
Done