Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34529 )
Change subject: soc/nvidia/tegra210: Prevent implicit integer promotion
......................................................................
Patch Set 1:
IIRC we had some sort of general agreement in coreboot that we don't care about -Wshift-overflow=2 and don't want to litter all our code with casts just to work around this purely theoretical non-problem? If so, wouldn't this be the same kind of issue, and shouldn't we then equally ignore it?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34529
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iaf0fb1040ccafafde0093e9bb192c802b86cb2ac
Gerrit-Change-Number: 34529
Gerrit-PatchSet: 1
Gerrit-Owner: Jacob Garber
jgarber1@ualberta.ca
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Jacob Garber
jgarber1@ualberta.ca
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 23 Jul 2019 23:09:08 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment