Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45845 )
Change subject: soc/intel/xeon_sp/cpx: Add soc_acpi_fill_fadt()
......................................................................
Patch Set 10: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/45845/10/src/soc/intel/xeon_sp/cpx/...
File src/soc/intel/xeon_sp/cpx/acpi.c:
https://review.coreboot.org/c/coreboot/+/45845/10/src/soc/intel/xeon_sp/cpx/...
PS10, Line 176: The bit_width field intentionally overflows here.
That's a bold claim, but what is the intention?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45845
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9c04dd478aa5e0f1467e63d06da094128edd9650
Gerrit-Change-Number: 45845
Gerrit-PatchSet: 10
Gerrit-Owner: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Jay Talbott
JayTalbott@sysproconsulting.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 20 Oct 2020 18:42:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment