30 Mar
2020
30 Mar
'20
12:32 a.m.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39837 )
Change subject: mb/emulation/qemu-q35: Enable CHROMEOS as an option ......................................................................
Patch Set 2: Code-Review-1
(2 comments)
https://review.coreboot.org/c/coreboot/+/39837/2/src/mainboard/emulation/qem... File src/mainboard/emulation/qemu-q35/vboot-rwab-16M.fmd:
https://review.coreboot.org/c/coreboot/+/39837/2/src/mainboard/emulation/qem... PS2, Line 3: 0x1c0000 the fmap sections below do not add up to this.
https://review.coreboot.org/c/coreboot/+/39837/2/src/mainboard/emulation/qem... PS2, Line 5: 0x14ffc0 You can omit the size to make sure it automatically fills up the parent section.
--
To view, visit https://review.coreboot.org/c/coreboot/+/39837
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I24b4532ea961e68558663292c99d121f0a30ce3b
Gerrit-Change-Number: 39837
Gerrit-PatchSet: 2
Gerrit-Owner: Duncan Laurie dlaurie@chromium.org
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Sun, 29 Mar 2020 22:32:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment