Naresh Solanki has posted comments on this change. ( https://review.coreboot.org/26940 )
Change subject: soc/intel/skylake: Enable low power S0Idle capability ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/#/c/26940/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/26940/2//COMMIT_MSG@11 PS2, Line 11: FSPUPD Which FSP UPD is being set?
https://review.coreboot.org/#/c/26940/2/src/soc/intel/skylake/acpi.c File src/soc/intel/skylake/acpi.c:
https://review.coreboot.org/#/c/26940/2/src/soc/intel/skylake/acpi.c@238 PS2, Line 238: dev Do NULL check before de-referencing pointer: const struct soc_intel_skylake_config *config = dev ? dev->chip_info : NULL;
https://review.coreboot.org/#/c/26940/2/src/soc/intel/skylake/acpi.c@287 PS2, Line 287: if (config->s0ix_enable) NULL check of pointer config before it is dereferenced. if (config && config->s0ix_enable)