Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41209 )
Change subject: fw_config: Add firmware configuration interface ......................................................................
Patch Set 2:
(1 comment)
This change is ready for review.
https://review.coreboot.org/c/coreboot/+/41209/2/src/include/fw_config.h File src/include/fw_config.h:
https://review.coreboot.org/c/coreboot/+/41209/2/src/include/fw_config.h@9 PS2, Line 9:
So if you try to provide something from the mainboard itself it has to be included indirectly from another chip.
Right, but you have to include <fw_config.h> anyway (for the macros), right? That's what I'm saying, just add #include <board/fw_config.h> here (to <fw_config.h>), add an -I $(src)/mainboard/$(MAINBOARDDIR)/include to the toplevel Makefile.inc (or to the mainboard-specific Makefile.inc), and put your board-specific file in src/mainboard/google/volteer/include/board/fw_config.h. Then if any devicetree driver uses fw_config it will #include <fw_config.h> from its <chip.h>, that will chain include <board/fw_config.h> and that should provide all the definitions to static.c. (You can also have that mainboard-specific header pull in a variant-specific header if you want, of course.)
That is what I said, you have to chain include it which is pretty ugly. Not that it is impossible.
Yes, but again only for the stuff that stage is actually using (and probably still considerably less, since many of your strings are smaller than the size of the (potentially) 64-bit pointer pointing to them).
Not if you want to print any debug, you don't know what options are selected so you don't know what strings you need.