Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/41682 )
Change subject: src: Remove unused '#include <cbfs.h>' ......................................................................
src: Remove unused '#include <cbfs.h>'
Found using: diff <(git grep -l '#include <cbfs.h>' -- src/) <(git grep -l 'cbfs_boot_map_optionrom|cbfs_boot_map_optionrom_revision|cbfs_boot_locate|cbfs_boot_map_with_leak|cbfs_locate_file_in_region|cbfs_boot_load_file|cbfs_load_and_decompress|cbfs_prog_stage_load|cbfs_boot_region_device' -- src/) |grep '<' |grep -v vendorcode
Also add missing 'include <cbfs.h>' in src/soc/qualcomm/sc7180/qupv3_config.c
Change-Id: Icaecb5b910888f34cddedab7b2f64eaf6d01ad66 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/41682 Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Wim Vervoorn wvervoorn@eltan.com Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/arch/riscv/fit_payload.c M src/drivers/pc80/rtc/mc146818rtc.c M src/mainboard/facebook/fbg1701/romstage.c M src/mainboard/intel/cannonlake_rvp/romstage_fsp_params.c M src/mainboard/intel/kblrvp/romstage.c M src/mainboard/intel/tglrvp/romstage_fsp_params.c M src/mainboard/portwell/m107/romstage.c M src/mainboard/sifive/hifive-unleashed/media.c M src/soc/intel/apollolake/mmap_boot.c M src/soc/intel/xeon_sp/cpx/chip.c 10 files changed, 0 insertions(+), 10 deletions(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Wim Vervoorn: Looks good to me, approved Angel Pons: Looks good to me, approved
diff --git a/src/arch/riscv/fit_payload.c b/src/arch/riscv/fit_payload.c index 2e676c7..abce57e 100644 --- a/src/arch/riscv/fit_payload.c +++ b/src/arch/riscv/fit_payload.c @@ -1,6 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-or-later */
-#include <cbfs.h> #include <commonlib/bsd/compression.h> #include <console/console.h> #include <bootmem.h> diff --git a/src/drivers/pc80/rtc/mc146818rtc.c b/src/drivers/pc80/rtc/mc146818rtc.c index 79bb5eb..3227510 100644 --- a/src/drivers/pc80/rtc/mc146818rtc.c +++ b/src/drivers/pc80/rtc/mc146818rtc.c @@ -9,7 +9,6 @@ #include <option.h> #include <pc80/mc146818rtc.h> #include <rtc.h> -#include <cbfs.h> #include <security/vboot/vbnv.h> #include <security/vboot/vbnv_layout.h> #include <types.h> diff --git a/src/mainboard/facebook/fbg1701/romstage.c b/src/mainboard/facebook/fbg1701/romstage.c index 6dafd8a..f307f95 100644 --- a/src/mainboard/facebook/fbg1701/romstage.c +++ b/src/mainboard/facebook/fbg1701/romstage.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */
#include <build.h> -#include <cbfs.h> #include <console/console.h> #include <chip.h> #include <device/pci_ops.h> diff --git a/src/mainboard/intel/cannonlake_rvp/romstage_fsp_params.c b/src/mainboard/intel/cannonlake_rvp/romstage_fsp_params.c index 2cd8637..5b7445f 100644 --- a/src/mainboard/intel/cannonlake_rvp/romstage_fsp_params.c +++ b/src/mainboard/intel/cannonlake_rvp/romstage_fsp_params.c @@ -1,6 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-#include <cbfs.h> #include <console/console.h> #include <fsp/api.h> #include <soc/romstage.h> diff --git a/src/mainboard/intel/kblrvp/romstage.c b/src/mainboard/intel/kblrvp/romstage.c index 281a24f..a3fb285 100644 --- a/src/mainboard/intel/kblrvp/romstage.c +++ b/src/mainboard/intel/kblrvp/romstage.c @@ -1,6 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-#include <cbfs.h> #include <console/console.h> #include <fsp/api.h> #include <gpio.h> diff --git a/src/mainboard/intel/tglrvp/romstage_fsp_params.c b/src/mainboard/intel/tglrvp/romstage_fsp_params.c index d4433a1..47507f4 100644 --- a/src/mainboard/intel/tglrvp/romstage_fsp_params.c +++ b/src/mainboard/intel/tglrvp/romstage_fsp_params.c @@ -6,7 +6,6 @@ #include <spd_bin.h> #include <soc/meminit.h> #include <baseboard/variants.h> -#include <cbfs.h> #include "board_id.h" #include "spd/spd.h"
diff --git a/src/mainboard/portwell/m107/romstage.c b/src/mainboard/portwell/m107/romstage.c index 4f666e2..3ba12f3 100644 --- a/src/mainboard/portwell/m107/romstage.c +++ b/src/mainboard/portwell/m107/romstage.c @@ -1,6 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-#include <cbfs.h> #include <console/console.h> #include <chip.h> #include <device/pci_ops.h> diff --git a/src/mainboard/sifive/hifive-unleashed/media.c b/src/mainboard/sifive/hifive-unleashed/media.c index 9f91bcb..2ba6d2b 100644 --- a/src/mainboard/sifive/hifive-unleashed/media.c +++ b/src/mainboard/sifive/hifive-unleashed/media.c @@ -2,7 +2,6 @@
#include <boot_device.h> #include <symbols.h> -#include <cbfs.h> #include <device/mmio.h> #include <soc/addressmap.h> #include <soc/spi.h> diff --git a/src/soc/intel/apollolake/mmap_boot.c b/src/soc/intel/apollolake/mmap_boot.c index b37d760..30c629e 100644 --- a/src/soc/intel/apollolake/mmap_boot.c +++ b/src/soc/intel/apollolake/mmap_boot.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-or-later */
#include <boot_device.h> -#include <cbfs.h> #include <commonlib/region.h> #include <console/console.h> #include <fmap.h> diff --git a/src/soc/intel/xeon_sp/cpx/chip.c b/src/soc/intel/xeon_sp/cpx/chip.c index 2125f0a..c19c0cf 100644 --- a/src/soc/intel/xeon_sp/cpx/chip.c +++ b/src/soc/intel/xeon_sp/cpx/chip.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */
#include <arch/ioapic.h> -#include <cbfs.h> #include <console/console.h> #include <cpu/x86/lapic.h> #include <device/pci.h>