Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35017 )
Change subject: mediatek/mt8183: Set DRAM voltage for each DRAM frequency
......................................................................
Patch Set 6:
(3 comments)
https://review.coreboot.org/c/coreboot/+/35017/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/35017/2//COMMIT_MSG@7
PS2, Line 7: vlotage
voltage
Done
https://review.coreboot.org/c/coreboot/+/35017/2//COMMIT_MSG@7
PS2, Line 7: vlotage
voltage
Done
https://review.coreboot.org/c/coreboot/+/35017/5/src/soc/mediatek/mt8183/emi...
File src/soc/mediatek/mt8183/emi.c:
https://review.coreboot.org/c/coreboot/+/35017/5/src/soc/mediatek/mt8183/emi...
PS5, Line 47: voltage_LP4X
Use lower case variable names.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35017
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9539473ff708f9d0d39eb17bd3fdcb916265d33e
Gerrit-Change-Number: 35017
Gerrit-PatchSet: 6
Gerrit-Owner: huayang duan
huayangduan@gmail.com
Gerrit-Reviewer: Huayang Duan
huayang.duan@mediatek.corp-partner.google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: hsin-hsiung wang
hsin-hsiung.wang@mediatek.com
Gerrit-Reviewer: huayang duan
huayangduan@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 02 Sep 2019 06:32:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment