Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44862 )
Change subject: mb/google/zork: update DRAM table for berknip
......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/44862/4/src/mainboard/google/zork/v...
File src/mainboard/google/zork/variants/berknip/spd/mem_parts_used.txt:
https://review.coreboot.org/c/coreboot/+/44862/4/src/mainboard/google/zork/v...
PS4, Line 8: 9
Why is this part being assigned ID 9? We should let the tool select the ID. Was this part already used in some build?
https://review.coreboot.org/c/coreboot/+/44862/4/src/mainboard/google/zork/v...
PS4, Line 9: 10
Same here.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44862
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia21a561e9b89feeccb6509d9280eaf52cfc2f5a3
Gerrit-Change-Number: 44862
Gerrit-PatchSet: 4
Gerrit-Owner: Kevin Chiu
Kevin.Chiu@quantatw.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 31 Aug 2020 18:42:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment