Reto Buerki has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/27154 )
Change subject: gma pipe setup: Fix secondary pipe cursors <= Sandy Bridge ......................................................................
Patch Set 3:
(3 comments)
https://review.coreboot.org/#/c/27154/3/common/hw-gfx-gma-pipe_setup.ads File common/hw-gfx-gma-pipe_setup.ads:
https://review.coreboot.org/#/c/27154/3/common/hw-gfx-gma-pipe_setup.ads@244 PS3, Line 244: FBC_CTL : Registers.Registers_Invalid_Index; Minor: Remove one whitespace before :?
https://review.coreboot.org/#/c/27154/3/common/hw-gfx-gma-pipe_setup.ads@274 PS3, Line 274: FBC_CTL => Registers.CUR_FBC_CTL_C))); Minor: Remove one whitespace before =>?
https://review.coreboot.org/#/c/27154/3/common/hw-gfx-gma.ads File common/hw-gfx-gma.ads:
https://review.coreboot.org/#/c/27154/3/common/hw-gfx-gma.ads@141 PS3, Line 141: "Reading of Config_State depends on the platform configuration.");
Yes. In cases where GMA.Config_State is actually read, it is runtime […]
Ok thanks for the explanation.