Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36176 )
Change subject: RFC) src/acpi: Update license headers to SPDX ......................................................................
Patch Set 1: Code-Review+1
(2 comments)
I like it somehow. Though, don't remember why we decided against it, the last time it came up.
https://review.coreboot.org/c/coreboot/+/36176/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/36176/1//COMMIT_MSG@12 PS1, Line 12: Linux has moved completely to SPDX headers I must have missed that. Or at least the DRM drivers I visit most often must have ;)
https://review.coreboot.org/c/coreboot/+/36176/1/src/acpi/sata.h File src/acpi/sata.h:
https://review.coreboot.org/c/coreboot/+/36176/1/src/acpi/sata.h@1 PS1, Line 1: // SPDX-License-Identifier: GPL-2.0-only No strong feelings about the SPDX. But is the C++ style // comment necessary? I don't mind too much, but mixing the styles seems odd.