Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41687 )
Change subject: [REJECTED] mb/supermicro/x9scl: Select IPMI_KCS
......................................................................
Patch Set 5:
Patch Set 3:
Patch Set 3:
This is dependency to CB:35086 so please come up with some plan.
Why is this a dependency? I dont see any code in here where CB:35086 is dependent on. What about rebasing CB:35086 and removing this from the relation chain?
CB:35086 removes weak declarations for devicetree ops. So, adding a "chip" entry without building the associated driver becomes a build-time error. This change is to make this mainboard build after CB:35086 lands, as it has a `chip drivers/ipmi` entry in the devicetree, but does not build in the IPMI KCS driver.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41687
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ice70aab7cedaeb91a33dd90d763c5a487f190b8f
Gerrit-Change-Number: 41687
Gerrit-PatchSet: 5
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Jonathan Kollasch
jakllsch@kollasch.net
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Christian Walter
christian.walter@9elements.com
Gerrit-Comment-Date: Fri, 03 Jul 2020 08:55:35 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment