Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36557 )
Change subject: soc/nvidia/tegra210: Populate _cbmem_top_ptr
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36557/4/src/soc/nvidia/tegra210/ram...
File src/soc/nvidia/tegra210/ramstage.c:
https://review.coreboot.org/c/coreboot/+/36557/4/src/soc/nvidia/tegra210/ram...
PS4, Line 79: _cbmem_top_ptr = (uintptr_t)cbmem_top_chipset();
Why is this not done earlier? isn't the printk() above, for instance,
potentially trying to use CBMEM?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36557
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8799c12705e944162c05fb7225ae21d32a2a882b
Gerrit-Change-Number: 36557
Gerrit-PatchSet: 5
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Comment-Date: Mon, 04 Nov 2019 14:43:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment