Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/80265?usp=email )
Change subject: vc/amd/opensil/genoa_poc/memmap: use unsigned long for resource index ......................................................................
vc/amd/opensil/genoa_poc/memmap: use unsigned long for resource index
Use an unsigned long as resource index type instead of an int to match the data type used for the index in the resource struct and the functions to report the resources.
Signed-off-by: Felix Held felix-coreboot@felixheld.de Change-Id: Iccc2e0556ce8688d933506e0db5cc4b83c66ac76 Reviewed-on: https://review.coreboot.org/c/coreboot/+/80265 Reviewed-by: Arthur Heymans arthur@aheymans.xyz Reviewed-by: Varshit Pandya pandyavarshit@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/vendorcode/amd/opensil/genoa_poc/memmap.c M src/vendorcode/amd/opensil/genoa_poc/opensil.h 2 files changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Arthur Heymans: Looks good to me, approved Varshit Pandya: Looks good to me, approved
diff --git a/src/vendorcode/amd/opensil/genoa_poc/memmap.c b/src/vendorcode/amd/opensil/genoa_poc/memmap.c index 4e5b457..8b54b5f 100644 --- a/src/vendorcode/amd/opensil/genoa_poc/memmap.c +++ b/src/vendorcode/amd/opensil/genoa_poc/memmap.c @@ -84,7 +84,7 @@ BOOT_STATE_INIT_ENTRY(BS_DEV_RESOURCES, BS_ON_ENTRY, print_memory_holes, NULL);
// This assumes holes are allocated -int add_opensil_memmap(struct device *dev, int idx) +unsigned long add_opensil_memmap(struct device *dev, unsigned long idx) { ram_from_to(dev, idx++, 0, 0xa0000); mmio_from_to(dev, idx++, 0xa0000, 0xc0000); // legacy VGA diff --git a/src/vendorcode/amd/opensil/genoa_poc/opensil.h b/src/vendorcode/amd/opensil/genoa_poc/opensil.h index 473238d..77b3c4b 100644 --- a/src/vendorcode/amd/opensil/genoa_poc/opensil.h +++ b/src/vendorcode/amd/opensil/genoa_poc/opensil.h @@ -8,7 +8,7 @@
void SIL_STATUS_report(const char *function, const int status); // Add the memory map to dev, starting at index idx, returns last use idx -int add_opensil_memmap(struct device *dev, int idx); +unsigned long add_opensil_memmap(struct device *dev, unsigned long idx); // Fill in FADT from openSIL void opensil_fill_fadt_io_ports(acpi_fadt_t *fadt);