build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35960 )
Change subject: trogdor: libpayload uart/serial driver support
......................................................................
Patch Set 27:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35960/27/payloads/libpayload/driver...
File payloads/libpayload/drivers/serial/qcom_qupv3_serial.c:
https://review.coreboot.org/c/coreboot/+/35960/27/payloads/libpayload/driver...
PS27, Line 32: /* For simplicity sake let's rely on coreboot initalizing the UART. */
'initalizing' may be misspelled - perhaps 'initializing'?
https://review.coreboot.org/c/coreboot/+/35960/27/payloads/libpayload/driver...
PS27, Line 286: while (read32(®s->geni_status) &
trailing statements should be on next line
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35960
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5be3904298cd88c60dbc6d8d662beeede2abe442
Gerrit-Change-Number: 35960
Gerrit-PatchSet: 27
Gerrit-Owner: mturney mturney
mturney@codeaurora.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Ravi kumar
rbokka@codeaurora.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: mturney mturney
mturney@codeaurora.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Roja Rani Yarubandi
c_rojay@qualcomm.corp-partner.google.com
Gerrit-Comment-Date: Wed, 05 Feb 2020 01:20:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment