V Sowmya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35228 )
Change subject: src/soc/intel/{common,cnl,skl,icl}: Move global reset req function to common
......................................................................
Patch Set 18:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35228/18/src/soc/intel/common/block...
File src/soc/intel/common/block/cse/cse.c:
https://review.coreboot.org/c/coreboot/+/35228/18/src/soc/intel/common/block...
PS18, Line 572: int send_heci_global_reset_req_message(uint8_t rst_type)
Since this function supports all the HOST, CSE and GLOBAL reset types can we change/retain the earlier function name?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35228
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I691fc0610356ef1f64ffa7cc4fe7a39b1344cc16
Gerrit-Change-Number: 35228
Gerrit-PatchSet: 18
Gerrit-Owner: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 12 Sep 2019 05:14:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment