Stephen Boyd has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35499 )
Change subject: sc7180: Add QUPv3 FW load & config
......................................................................
Patch Set 15:
Patch Set 15:
Patch Set 15:
(8 comments)
Note that this patch is going to essentially go away anyway and the whole QUP firmware loading should be redesigned according to the discussion in CB:25372, so I haven't been looking too closely at it. But we should make sure we're at least loading the right kind of firmware on all QUPs in the meantime (so we should add the I2C for 0SE5).
Ok. I believe the existing protocols are all correct, just the comments are wrong and we're missing on i2c for the SAR.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35499
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4d91dd10488931247f81a87b0bdcc598f4bceb31
Gerrit-Change-Number: 35499
Gerrit-PatchSet: 15
Gerrit-Owner: mturney mturney
mturney@codeaurora.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Ravi kumar
rbokka@codeaurora.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: mturney mturney
mturney@codeaurora.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Patrick Rudolph
siro@das-labor.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Stephen Boyd
swboyd@chromium.org
Gerrit-Comment-Date: Tue, 19 Nov 2019 21:09:18 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment