15 Jan
2019
15 Jan
'19
11:48 p.m.
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30845 )
Change subject: mb/emulation/qemu-i440fx: change file handling ......................................................................
Patch Set 4: Code-Review+2
(1 comment)
https://review.coreboot.org/#/c/30845/4/src/mainboard/emulation/qemu-i440fx/... File src/mainboard/emulation/qemu-i440fx/fw_cfg.h:
https://review.coreboot.org/#/c/30845/4/src/mainboard/emulation/qemu-i440fx/... PS4, Line 15: f I'd prefer not to include the private header. The only solution I see would be to introduce additional functions to return file->size and file->select.
--
To view, visit https://review.coreboot.org/c/coreboot/+/30845
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I48cc943aaa999e4323e9d7e5dd666c5316533dcc
Gerrit-Change-Number: 30845
Gerrit-PatchSet: 4
Gerrit-Owner: Thomas Heijligen src@posteo.de
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 16 Jan 2019 07:48:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment