Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36823 )
Change subject: soc/amd/stoneyridge/kconfig: Make Prairie Falcon selection explicit ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/36823/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/36823/1//COMMIT_MSG@16 PS1, Line 16: only Stoneyridge is combo capable
To be more clear, we never build combo directories. […]
So I confused some... yes SMU firmware. However, that's how I changed the code, with only stoney being combo capable , not enabling it for Prairie Falcon. Was I wrong, and thus should enable it also for Prairie Falcon?
https://review.coreboot.org/c/coreboot/+/36823/1//COMMIT_MSG@18 PS1, Line 18: Merlin Falcon uses the same internal CPU as Carrizo, thus it has dual memory : channel while Prairie Falcon and Stoney ridge have only one channel.
It's not that the comparison is invalid. […]
Will remove