Attention is currently required from: Lance Zhao, Furquan Shaikh, Tim Wawrzynczak.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55027 )
Change subject: acpi/device: Add ability to generate proper _STA for PowerResource
......................................................................
Patch Set 3:
(2 comments)
File src/acpi/device.c:
https://review.coreboot.org/c/coreboot/+/55027/comment/7c6c9ffc_98d181e9
PS2, Line 649: 0x1
Since a PowerResources uses the return value of _STA differently than a Device, how about adding new […]
Done
File src/include/acpi/acpi_device.h:
https://review.coreboot.org/c/coreboot/+/55027/comment/2c325b6b_ba6eb81a
PS2, Line 459:
: /* Write a _STA method that checks the state of the GPIOs. Otherwise
: * the _STA method will always return _ON.
: */
: bool enable_status;
that's good, also +1.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55027
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I91410556db002c620fd9aaa99981457808da93a5
Gerrit-Change-Number: 55027
Gerrit-PatchSet: 3
Gerrit-Owner: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Lance Zhao
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Comment-Date: Thu, 03 Jun 2021 21:35:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Lance Zhao
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment