Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Mohan Viswanathan, Name of user not set #1004133, Al Hirani, Avinash Alevoor, Rob Barnes, Fred Reitberger, Felix Held.
Jason Glenesk has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61462 )
Change subject: soc/amd/common/block/psp: add PSP command
......................................................................
Patch Set 5:
(3 comments)
File src/soc/amd/common/block/psp/psp.c:
PS4:
this is psp gen 2 specific, so it needs to be moved to psp_gen2. […]
Done
File src/soc/amd/common/block/psp/psp_def.h:
https://review.coreboot.org/c/coreboot/+/61462/comment/099153dc_94cebf42
PS4, Line 21: #define MBOX_BIOS_CMD_SET_SPL_FUSE 0x2d
: #define MBOX_BIOS_CMD_QUERY_SPL_FUSE 0x47
those two should be above MBOX_BIOS_CMD_ABORT so that those are in ascending order
Done
https://review.coreboot.org/c/coreboot/+/61462/comment/b78495b4_1d628c57
PS4, Line 29: 10998
should this be 0x10998?
Confirmed with Avinash it is hex. Need to go back and look at the other C2P code that i used as reference.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61462
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If0575356a7c6172e2e0f2eaf9d1a6706468fe92d
Gerrit-Change-Number: 61462
Gerrit-PatchSet: 5
Gerrit-Owner: Jason Glenesk
jason.glenesk@amd.corp-partner.google.com
Gerrit-Reviewer: Al Hirani
al.hirani13@gmail.com
Gerrit-Reviewer: Avinash Alevoor
Gerrit-Reviewer: Fred Reitberger
fred.reitberger@amd.corp-partner.google.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Mohan Viswanathan
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Name of user not set #1004133
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Mohan Viswanathan
Gerrit-Attention: Name of user not set #1004133
Gerrit-Attention: Al Hirani
al.hirani13@gmail.com
Gerrit-Attention: Avinash Alevoor
Gerrit-Attention: Rob Barnes
robbarnes@google.com
Gerrit-Attention: Fred Reitberger
fred.reitberger@amd.corp-partner.google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Wed, 02 Feb 2022 22:42:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment