Attention is currently required from: Lance Zhao. Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51578 )
Change subject: acpi: Add DRTM table definition ......................................................................
Patch Set 2:
(3 comments)
File src/include/acpi/acpi.h:
https://review.coreboot.org/c/coreboot/+/51578/comment/9a586336_f82fd393 PS2, Line 75: DRTM
Original people have those names in order from A~Z, but that seems breaked by ECDT and LPIT.
Okay, I will arrange them A~Z
https://review.coreboot.org/c/coreboot/+/51578/comment/29b0b1c6_4db99311 PS2, Line 577: /* drtm_validated_tables_list_t : drtm_resources_t : drtm_dps_t */
For future or anything else? Please list the reason here or in commit.
These are the contents of DRTM ACPI table, however due to multiple undefined length tables along the way (and not at the end of the table), we cannot put it inside the structure.
https://review.coreboot.org/c/coreboot/+/51578/comment/42d0b4ff_0f3022bf PS2, Line 600: u64 dps_supported[2]
shall that be […]
According to https://trustedcomputinggroup.org/wp-content/uploads/TCG_D-RTM_Architecture_... section 4.6.3.5 these fields are 64 bit long.