HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30993 )
Change subject: nb/intel/i945: Use macro instead of magic number ......................................................................
Patch Set 2:
(4 comments)
https://review.coreboot.org/#/c/30993/2/src/northbridge/intel/i945/early_ini... File src/northbridge/intel/i945/early_init.c:
https://review.coreboot.org/#/c/30993/2/src/northbridge/intel/i945/early_ini... PS2, Line 349: 810 this RO and reserved bits. and inany case , it will never happen as it is already done at ich7_setup_root_complex_topology function. (this RCBA register is R/WO)
https://review.coreboot.org/#/c/30993/2/src/northbridge/intel/i945/early_ini... PS2, Line 371: RCBA32(ESD) |= (2 << 16); : : RCBA32(ULD) |= (1 << 24) | (1 << 16); : : RCBA32(ULBA) = (uintptr_t)DEFAULT_DMIBAR; this will never happen the registers are R/WO and we already did it at function ich7_setup_root_complex_topology()
https://review.coreboot.org/#/c/30993/2/src/northbridge/intel/i945/early_ini... PS2, Line 887: 802 this RO and reserved. so is this write needed ?
https://review.coreboot.org/#/c/30993/2/src/northbridge/intel/i945/early_ini... PS2, Line 889: 1 this write do not make sense this bit is RO if I'm not wrong