Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60058 )
Change subject: soc/intel/cannonlake: Call `meminit_memcfg()` only once ......................................................................
soc/intel/cannonlake: Call `meminit_memcfg()` only once
`meminit_memcfg()` does common memory configuration, which is not specific to each dimm. Thus, move it out of the for-loop and call it once.
Change-Id: If74875b45cd0d7a759883eaf564505ebf281bed5 Signed-off-by: Felix Singer felixsinger@posteo.net --- M src/soc/intel/cannonlake/cnl_memcfg_init.c 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/60058/1
diff --git a/src/soc/intel/cannonlake/cnl_memcfg_init.c b/src/soc/intel/cannonlake/cnl_memcfg_init.c index a9f9e95..448e56c 100644 --- a/src/soc/intel/cannonlake/cnl_memcfg_init.c +++ b/src/soc/intel/cannonlake/cnl_memcfg_init.c @@ -136,7 +136,7 @@ default: die("no valid way to read mem info"); } - - meminit_memcfg(mem_cfg, cnl_cfg); } + + meminit_memcfg(mem_cfg, cnl_cfg); }