Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39115 )
Change subject: mb/google/dedede: Add WLAN configuration ......................................................................
Patch Set 7:
(3 comments)
https://review.coreboot.org/c/coreboot/+/39115/5/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/39115/5/src/mainboard/google/dedede... PS5, Line 154: PAD_CFG_GPI_SCI_LOW
For PCIe based WLAN to trigger interrupt to AP when AP is in S0 state.
Don't you need to configure the line to be routed to APIC in that case? Also, how does the kernel driver get to know about this interrupt line? Is it exposed in ACPI?
https://review.coreboot.org/c/coreboot/+/39115/5/src/mainboard/google/dedede... PS5, Line 188: PAD_CFG_NF(GPP_D19, NONE, DEEP, NF2), : /* D20 : WWAN_WLAN_COEX2 */ : PAD_CFG_NF(GPP_D20, NONE, DEEP, NF2), : /* D21 : WWAN_WLAN_COEX3 */ : PAD_CFG_NF(GPP_D21, NONE, DEEP, NF1),
Based on the EDS, GPP_D19/20 are configured for PCIe and GPP_D21 for CNVi. […]
Interesting. It would be good to check with Intel on this. I believe we would want all lines to be configured for CNVi when using that.
https://review.coreboot.org/c/coreboot/+/39115/5/src/mainboard/google/dedede... PS5, Line 385: PAD_CFG_NF(GPD9, NONE, DEEP, NF1),
You are correct. […]
No. I don't think we ever use it. This can be just left as PAD_NC