Duan huayang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44569 )
Change subject: soc/mediatek/mt8192: Do dram fast calibration ......................................................................
Patch Set 1:
(5 comments)
https://review.coreboot.org/c/coreboot/+/44569/1/src/soc/mediatek/mt8192/Kco... File src/soc/mediatek/mt8192/Kconfig:
https://review.coreboot.org/c/coreboot/+/44569/1/src/soc/mediatek/mt8192/Kco... PS1, Line 26: n
I think we're always going to always use EMCP, so this should default to y?
Done
https://review.coreboot.org/c/coreboot/+/44569/1/src/soc/mediatek/mt8192/mem... File src/soc/mediatek/mt8192/memory.c:
https://review.coreboot.org/c/coreboot/+/44569/1/src/soc/mediatek/mt8192/mem... PS1, Line 8: #include <security/vboot/vboot_common.h>
you don't need this in current implementation (may need it in follow up, but let's discuss later)
Done
https://review.coreboot.org/c/coreboot/+/44569/1/src/soc/mediatek/mt8192/mem... PS1, Line 97: 0xa5
why not 0xff? A5 implies there'll be additional writes after erasing (0xff)
I just want to have a distinguish with the default value(0xff).
https://review.coreboot.org/c/coreboot/+/44569/1/src/soc/mediatek/mt8192/mem... PS1, Line 126: setup_dramc_voltage_before_calibration();
I think you can just remove the empty function and this call. Add them only when really needed.
Done
https://review.coreboot.org/c/coreboot/+/44569/1/src/soc/mediatek/mt8192/mem... PS1, Line 128: restore_dramc_voltage_after_calibration();
I think you can just remove the empty function and this call. Add them only when really needed.
Done