Attention is currently required from: Keith Hui, Tim Wawrzynczak, Angel Pons.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52642 )
Change subject: cpu/x86/mtrr: Prefer keeping WRCOMB requests to reserving MTRRs for OS
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
True, this turns it fully into an "advisory" in terms of coreboot, it will now happily keep WC reque […]
It just seems really weird to add a Kconfig in one commit and cripple it
in the very next. Either we feel safe that Slot1 platforms won't need that
many MTRRs (or the OS wouldn't know how to do better anyway), or we need
that Kconfig option. It doesn't seem that there were new revelations since
the parent commit?
Should we just try to find somebody to look into it? My preference would be
no Kconfig at all and always printing the message at level info. But for
that we'd need to know how things are on the old platforms.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52642
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I108c743d25baaeae1860732601cc7abda2f05932
Gerrit-Change-Number: 52642
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Keith Hui
buurin@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Georgi
pgeorgi@google.com
Gerrit-Attention: Keith Hui
buurin@gmail.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Fri, 30 Apr 2021 15:21:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment