Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40244 )
Change subject: soc/tigerlake: Add devicetree configurability for IomTypeCPortPadCfg
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40244/1/src/soc/intel/tigerlake/chi...
File src/soc/intel/tigerlake/chip.h:
https://review.coreboot.org/c/coreboot/+/40244/1/src/soc/intel/tigerlake/chi...
PS1, Line 234: 8
If you want to revive this I think it's easier split this out by port. I'm failing to understand the comment '0, 1 for port 0' and why this dimension is 8. And why this is a 32-bit wide variable. I think we should make these configs as straight forward as possible and manipulate the data to match the UPD expectations, even if the interface is confusing. I'd like to see that for all these options, tbh.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40244
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2e48adb624c7922170eafb8dfcaed680f008936e
Gerrit-Change-Number: 40244
Gerrit-PatchSet: 1
Gerrit-Owner: Brandon Breitenstein
brandon.breitenstein@intel.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 07 Apr 2020 22:14:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment