Attention is currently required from: Martin L Roth, Jon Murphy, Won Chung, Rob Barnes, Karthik Ramasubramanian, Felix Held.
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64670 )
Change subject: mb/google/guybrush: Add better descriptors for USB endpoints
......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/google/guybrush/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/64670/comment/7d26e1c6_a0e16849
PS2, Line 293: USB3
Hi Martin, […]
The port names don't mean anything to a user though. Left and right, front and rear, make at least some sense. C0 isn't going to give a user any information.
I agree that standard designation would be good, and I have no issue with including the type and port name in that description, but I still think it should be based on where the port is on the chassis. Mainboard/Daughterboard are again helpful to us, but without taking the chassis apart, it's just going go confuse a user, even if they know what a motherboard or daughterboard is.
Maybe this is something that the marketing team can figure out a standard for.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/64670
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5819b8894955fe45e539526460b7ef0adbd12a03
Gerrit-Change-Number: 64670
Gerrit-PatchSet: 2
Gerrit-Owner: Jon Murphy
jpmurphy@google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Martin L Roth
gaumless@tutanota.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Martin Roth
martinroth@google.com
Gerrit-CC: Won Chung
wonchung@google.com
Gerrit-Attention: Martin L Roth
gaumless@tutanota.com
Gerrit-Attention: Jon Murphy
jpmurphy@google.com
Gerrit-Attention: Won Chung
wonchung@google.com
Gerrit-Attention: Rob Barnes
robbarnes@google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Tue, 31 May 2022 22:15:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin L Roth
gaumless@tutanota.com
Comment-In-Reply-To: Won Chung
wonchung@google.com
Gerrit-MessageType: comment