Attention is currently required from: Matt DeVillier, Nico Huber.
Hello Matt DeVillier, Nico Huber, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/82592?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins)
Change subject: [UNTESTED, WIP] device/pci_rom: handle non-remapped VGA_BIOS_ID ......................................................................
[UNTESTED, WIP] device/pci_rom: handle non-remapped VGA_BIOS_ID
While the SoC-level defaults for VGA_BIOS_ID are the expected correctly remapped PCI ID of the GPU, some mainboards override the VGA_BIOS_ID setting to the non-remapped PCI ID. This resulted in coreboot not finding the VBIOS file. The proper solution would be to not override this SoC-level config in neither the mainboard code nor some external config file. This however requires adding some mechanism to be able to tell SeaBIOS which VBIOS image to use for the GPU device.
This sort-of reverts parts of commit 42f0396a1028 ("device/pci_rom: rework PCI ID remapping in pci_rom_probe"), but it still tries to find the VBIOS image with the expected remapped PCI ID and only adds trying the non-remapped PCI ID as a fallback when the file with the remapped PCI ID doesn't exist and prints a warning in that case.
Signed-off-by: Felix Held felix-coreboot@felixheld.de Change-Id: I7cd8e2036250f4ca2239b04cd070bbf0778b13aa --- M src/device/pci_rom.c 1 file changed, 10 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/82592/3