Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40929 )
Change subject: cpu: Add a helper function cpu_get_lapic_addr
......................................................................
Patch Set 4:
Patch Set 4:
I guess lapic is very x86 specific, but rather than a lot of #ifdefs in arch-independent code you could define these in the arch-dependent cpu headers.
Yeah, I thought about that but I was wondering if things would look really confusing having a "#define LOCAL_APIC_ADDR 0" in every cpu.h. I am fine either ways. Not having #ifdefs in arch-independent code is definitely nice.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40929
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4d9c50ee46804164712aaa22be1b434f800871ec
Gerrit-Change-Number: 40929
Gerrit-PatchSet: 4
Gerrit-Owner: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 01 May 2020 04:06:14 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment