[coreboot-gerrit] Change in coreboot[master]: superio/nuvoton/nct5539d: Update documentation and remove DSDT

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38864 )

Change subject: superio/nuvoton/nct5539d: Update documentation and remove DSDT
......................................................................

Patch Set 2:
> Patch Set 2:
> > Patch Set 2: Code-Review+2
> > > Patch Set 2:
> > > > Patch Set 2:
> > > > > Patch Set 2:
> > > > > > Patch Set 2:
> > > > > >
> > > > > > Tested, didn't go well, the system halts earlier than before. A bit lazy to create a full report but it's on the way (in few hours may be).
> > > > >
> > > > > https://pastebin.com/wCEDmiM4
> > > >
> > > > Looks like your devicetree is broken, as there are tons of "BUG: Check your devicetree!"
> > > > There's documentation how to use the SIO SSDT gen: https://doc.coreboot.org/superio/common/ssdt.html
> > >
> > > added ssdt option to the devicetree.cb and tested, https://drive.google.com/open?id=1eyPO_tEzJdNJ_pfDYLmsZ0R-1gJVPuNg
> >
> > I see no "BUG", so it works fine?
>
> To the point of "found /dev/ttyS0".

I can't decode the log.
It looks like it worked the first time as it printed "sky login"?
The earlyprintk isn't working as you only get late systemd messages.
Does it work with the dsdt acpi code?