Attention is currently required from: Nico Huber, Tim Wawrzynczak, Angel Pons, EricR Lai. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60470 )
Change subject: console: Create helper function to get max console log level ......................................................................
Patch Set 2:
(2 comments)
File src/console/init.c:
https://review.coreboot.org/c/coreboot/+/60470/comment/2fd8a1f6_aae4e08f PS2, Line 55: return get_log_level();
Looking further into the patch series, you only need the value returned by `get_log_level()`. […]
Initially I had the same understanding as well but later I realised that `get_log_level()` will return always Kconfig value irrespective of the console level. For example: irrespective of console type (CONSOLE_LOG_FAST), it will alway return '8' (BIOS_SPEW).
Will also let Nico to share his thoughts as he suggested to create console level to msg level function at the first place.
https://review.coreboot.org/c/coreboot/+/60470/comment/3ced0d42_6a7efcdb PS2, Line 57: -1
This will vanish with the changes suggested in my other comment.
-1 is kind of invalid so fsp can return `disable` as part of default switch case